Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the DI decorator's id in specific property (#5131). #5199

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Store the DI decorator's id in specific property (#5131). #5199

merged 2 commits into from
Jan 6, 2025

Conversation

asemdreibati
Copy link
Contributor

@asemdreibati asemdreibati commented Oct 29, 2024 •
edited
Loading

Should fix #5131

@asemdreibati
Copy link
Contributor Author

@Tyriar Can you review the PR, please?

@Tyriar Tyriar added this to the 6.0.0 milestone Jan 6, 2025
@Tyriar Tyriar self-assigned this Jan 6, 2025
Tyriar
Tyriar approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks!

@Tyriar Tyriar enabled auto-merge January 6, 2025 13:58
@Tyriar Tyriar merged commit af4208d into xtermjs:master Jan 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Prototype pollution protection breaks decorator functionality
2 participants
@asemdreibati @Tyriar